[pythonscripting] Fix python timedelta to java duration mapping #18671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
added
bug
jlaur
requested changes
May 10, 2025
| // picking two members to check as Duration has many common function names | ||
| v -> v.hasMember("total_seconds") && v.hasMember("total_seconds"), | ||
| v -> Duration.ofNanos(v.invokeMember("total_seconds").asLong() * 10000000), | ||
| v -> Duration.ofNanos(v.invokeMember("total_seconds").asLong() * 1000000000), |
There was a problem hiding this comment.
Suggested change
| v -> Duration.ofNanos(v.invokeMember("total_seconds").asLong() * 1000000000), | |
| v -> Duration.ofSeconds(v.invokeMember("total_seconds").asLong()), |
There was a problem hiding this comment.
another commit which fix the nano seconds accuracy and make it clear why we need "Duration.ofNanos"
rprescott308y
pushed a commit
to rprescott308y/openhab-addons
that referenced
this pull request
May 18, 2025
…hab#18671) * fix python timedelta to java duration mapping * fix duration accuracy
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
…hab#18671) * fix python timedelta to java duration mapping * fix duration accuracy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the mapping between a python timedelta to java Duration mapping
@jlaur can you please review?